Summary

This will move all files into the discord/ext/wavelink namespace. This is a way better implementation than the current one. It also allows seamless migration from the original library without using an alias when importing wavelink.

Following was tested:

• Installation
• Playing a track

Docs Build wasn't tested.

Checklist

• [x] If code changes were made then they have been tested.
  • [x] I have updated the documentation to reflect the changes.
• [ ] If type: ignore comments were used, a comment is also left explaining why
• [x] This PR fixes an issue. #15
• [ ] This PR adds something new (e.g. new method or parameters).
• [x] This PR is a breaking change (e.g. methods or parameters removed/renamed)
• [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Further possible improvements

To reflect this change, the pypi name and GitHub repo should be renamed to pycord-ext-wavelink or py-cord-ext-wavelink.

Due to the early state of the library it should be possible and all users would adapt to this change.

I think a smart implementation of this library would be as an extension by moving it into the discord/ext/wavelink namespace.

Also the library name currently is a bit unconventional. pycord-ext-wavelink or py-cord-ext-wavelink would be better by following the naming conventions from Danny (menu extension)

Reverts Pycord-Development/Pycord.Wavelink#34

The library seems to have broken after the mentioned PR. 1 previous version works perfectly without any code changes

Error-

Traceback (most recent call last):
  File "/home/container/.local/lib/python3.10/site-packages/discord/ext/commands/core.py", line 179, in wrapped
    ret = await coro(*args, **kwargs)
  File "/home/container/Cogs/Music.py", line 142, in play
    await vc.play(vc.queue.get())
  File "/home/container/.local/lib/python3.10/site-packages/pycord/wavelink/player.py", line 247, in play
    "guildId": str(self.guild.id),
  File "/home/container/.local/lib/python3.10/site-packages/pycord/wavelink/player.py", line 107, in guild
    return self.channel.guild
AttributeError: 'NoneType' object has no attribute 'guild'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/container/.local/lib/python3.10/site-packages/discord/ext/commands/bot.py", line 335, in invoke
    await ctx.command.invoke(ctx)
  File "/home/container/.local/lib/python3.10/site-packages/discord/ext/commands/core.py", line 916, in invoke
    await injected(*ctx.args, **ctx.kwargs)
  File "/home/container/.local/lib/python3.10/site-packages/discord/ext/commands/core.py", line 188, in wrapped
    raise CommandInvokeError(exc) from exc
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'NoneType' object has no attribute 'guild'

No song is playing on the channel after the client sends the request and the server is sending connected: False in websocket event.

2022-02-08 15:25:43,642 - pycord.wavelink.websocket - op: event:: {'op': 'event', 'type': 'TrackStartEvent', 'track': 'QAAAkgIALExpb25lbCBSaWNoaWUgLSBIZWxsbyAoT2ZmaWNpYWwgTXVzaWMgVmlkZW8pAAxsaW9uZWxyaWNoaWUAAAAAAAT9WAALbUhPTk5jWmJ3RFkAAQAraHR0cHM6Ly93d3cueW91dHViZS5jb20vd2F0Y2g/dj1tSE9OTmNaYndEWQAHeW91dHViZQAAAAAAAAAA', 'guildId': '822344738958344204'}
2022-02-08 15:25:48,459 - pycord.wavelink.websocket - Received Payload:: <{"op":"playerUpdate","state":{"connected":false,"position":0,"time":1644314148103},"guildId":"822344738958344204"}>
2022-02-08 15:25:48,461 - pycord.wavelink.websocket - op: playerUpdate:: {'op': 'playerUpdate', 'state': {'connected': False, 'position': 0, 'time': 1644314148103}, 'guildId': '822344738958344204'}
2022-02-08 15:25:53,581 - pycord.wavelink.websocket - Received Payload:: <{"op":"playerUpdate","state":{"connected":false,"position":0,"time":1644314153102},"guildId":"822344738958344204"}>
2022-02-08 15:25:53,584 - pycord.wavelink.websocket - op: playerUpdate:: {'op': 'playerUpdate', 'state': {'connected': False, 'position': 0, 'time': 1644314153102}, 'guildId': '822344738958344204'}
2022-02-08 15:25:58,378 - pycord.wavelink.websocket - Received Payload:: <{"op":"playerUpdate","state":{"connected":false,"position":0,"time":1644314158102},"guildId":"822344738958344204"}>
2022-02-08 15:25:58,380 - pycord.wavelink.websocket - op: playerUpdate:: {'op': 'playerUpdate', 'state': {'connected': False, 'position': 0, 'time': 1644314158102}, 'guildId': '822344738958344204'}

   async def get_player(self, obj: Union[ApplicationContext, discord.Guild]):
        if isinstance(obj, ApplicationContext):
            obj = obj.guild
        print(wavelink.NodePool._nodes)
        for node in wavelink.NodePool._nodes.values():
            player = node.get_player(obj)
            if player is not None:
                return player
        if player is None:
            player = Player(obj)
        return player 

I am trying to retrieve the player from the Pool using the above code but it's returning me the following error.

   player = node.get_player(obj)
  File "/home/pi/.local/lib/python3.10/site-packages/pycord/wavelink/pool.py", line 308, in get_player
    if player.guild == guild:
  File "/home/pi/.local/lib/python3.10/site-packages/pycord/wavelink/player.py", line 107, in guild
    return self.channel.guild
AttributeError: 'NoneType' object has no attribute 'guild'

wavelink.Client, wavelink.eqs.Equalizer, wavelink.meta.WavelinkMixin, and wavelink.events (such as wavelink.events.TrackEnd) were not brought over into the pycord version of wavelink

Summary

Every time I search for a song in SoundCloud with wavelink.SoundCloudTrack, it never returns anything. Rather, it raises a BadArgument exception stating that it could not find any songs matching that query.

Reproduction Steps

1. Run the Minimal Reproducible Code
2. Join a VC that your bot can join
3. Run the play command with your query of choice

Minimal Reproducible Code

Use the example code but replace the type annotation for the search argument from wavelink.YouTubeTrack to wavelink.SoundCloudTrack.

Expected Results

The bot would join the VC and play the song from a lavalink server's SoundCloud search with the query

Actual Results

Ignoring exception in command play:
Traceback (most recent call last):
  File "ProjectDir/venv/lib/python3.8/site-packages/discord/ext/commands/bot.py", line 335, in invoke
    await ctx.command.invoke(ctx)
  File "ProjectDir/venv/lib/python3.8/site-packages/discord/ext/commands/core.py", line 902, in invoke
    await self.prepare(ctx)
  File "ProjectDir/venv/lib/python3.8/site-packages/discord/ext/commands/core.py", line 832, in prepare
    await self._parse_arguments(ctx)
  File "ProjectDir/venv/lib/python3.8/site-packages/discord/ext/commands/core.py", line 747, in _parse_arguments
    kwargs[name] = await self.transform(ctx, param)
  File "ProjectDir/venv/lib/python3.8/site-packages/discord/ext/commands/core.py", line 590, in transform
    return await run_converters(ctx, converter, argument, param)  # type: ignore
  File "ProjectDir/venv/lib/python3.8/site-packages/discord/ext/commands/converter.py", line 1183, in run_converters
    return await _actual_conversion(ctx, converter, argument, param)
  File "ProjectDir/venv/lib/python3.8/site-packages/discord/ext/commands/converter.py", line 1075, in _actual_conversion
    return await converter.convert(ctx, argument)
  File "ProjectDir/pycord/wavelink/tracks.py", line 203, in convert
    raise commands.BadArgument("Could not find any songs matching that query.")
discord.ext.commands.errors.BadArgument: Could not find any songs matching that query.

Intents

None

System Information

Since I couldn't install the latest version, I, instead, cloned this repository to the latest commit (edaf4d7caedf797852d82d3e08faec9d89997ab7) and dragged the source code (the pycord directory inside of src) to the root project directory.

- Python 3.8.5
- py-cord v2.0.0-alpha
    - py-cord pkg_resources: v2.0.0a4688+g52fdbb1b
- aiohttp v3.7.4.post0
- system information: Darwin 20.6.0 Darwin Kernel Version 20.6.0: Wed Jun 23 00:26:31 PDT 2021; root:xnu-7195.141.2~5/RELEASE_X86_64

Summary

YouTube Music searches and returns Soundtracks before Music videos. Due to this nature, the quality tends to be better on Youtube Music searches.

Since Spotify is also primarily soundtracks based music streaming service, getting tracks from YTM seems more logical.

I've tested it to an extent. And the initial results look promising. This should be implemented in conjunction to #24

Checklist

• [x] If code changes were made then they have been tested.
  • [ ] I have updated the documentation to reflect the changes.
• [ ] If type: ignore comments were used, a comment is also left explaining why
• [] This PR fixes an issue.
• [x] This PR adds something new (e.g. new method or parameters).
• [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
• [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Summary

Add PlainTrack to the __all__ variable so it is recognised by IDEs I'm not sure how it affected the working of the object earlier, but now the code does work 😅

Checklist

• [x] If code changes were made then they have been tested.
  • [ ] I have updated the documentation to reflect the changes.
• [ ] If type: ignore comments were used, a comment is also left explaining why
• [x] This PR fixes an issue.
• [ ] This PR adds something new (e.g. new method or parameters).
• [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
• [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

So apparently songs on YouTube music are there on Youtube too, with the exact same video id. In fact, Youtube Music is just a layer on top of Youtube.

Subclassing YTM Track from YT Track gives it the thumbnail property. It is used to get the thumbnail of the video

If you know many music bots use self deafen method to deafen them. I know we can manually deafen the bots in the server but it looks cool when the bot is on self deafen, so i will suggest to add an attribute named selfdeafen.

Age Restricted content on YouTube appears to be unplayable currently. Lavalink shows that it loads whatever Age-Restricted video you throw at it, but there is no audio outputted by the bot.