In playing around with this wrapper, I tried to pull all of the fields available when geocoding an address. Heres my code:

r = '42370 Bob Hope Dr, Rancho Mirage CA' geocoded_location = client.geocode(r, fields=['cd','school'] )

This returns the 'school' attribute of fields, but not the 'cd'. I'd like to be able to pass more than one field and this doesn't not support this capability.

I would try to fix this myself, but I am not skilled enough in python.

Thanks.

This addresses #27

This is admittedly a very blunt approach to the problem: LocationCollectionDict is a version of LocationCollection that inherits from dictionary instead of list.

The batch geocoder endpoint for geocod.io accepts a JSON object. Currently batch_geocode only accepts lists of addresses. When a python dictionary of keys and addresses is passed to batch_geocode, the geocod.io interprets it as a JSON object and returns a JSON object in its response. The results field is now a JSON object rather than an array, which python interprets as a dictionary.

LocationCollection expects a list from response.json()["results"] and understandably breaks. If the response is instead a dictionary, it gets rerouted to LocationCollectionDict to create a comparable dictionary object. LocationCollectionDict changes the list methods in LocationCollection to dictionary methods

I get KeyErrors when I run the last two examples in the README https://github.com/bennylope/pygeocodio

locations.get("33.738987, -116.4083").formatted_address and locations.get((33.738987, -116.4083)).formatted_address

This moves the responsibility of validating field names to the server instead of the client.

In practice, this lets users request newer fields such as census2010, and ensures that the list in the library will not need to be continuously updated.

Related to: #30

Changes:

• Give geocode(...) 2 parameters: address_data + components_data
  • If both are populated or both are empty, nothing happens
  • If addres_data is provided (default first parameter), searching behaves like previusly
  • If comonents_data is a single dict or list of dicts populated with the supported fields here, geocoding occurs with components as the parameters instead of the freeform address string
• You can lookup a result based on the address components geocoded

Geocodio batch encoding allows for a reference key to be included if the request is submitted as a JSON object rather than a JSON array. See https://www.geocod.io/docs/#batch-geocoding

Can this functionality be added?

• Update client
• Update test client

v1.3 (Released on March 12th, 2018)

timezone appends:

Breaking: name property has been renamed to abbreviation name is now the full timezone name in a tzdb-compatible format.

Hello there,

It looks like this commit did not make it to the pip package manager. geocodio/init.py is still using the outdated format and client.py is still using version 1 of the Geocodio API: https://github.com/bennylope/pygeocodio/commit/9631d11da62f6e9a205a3b7430e34c556c601592

I am more than happy to do any testing, George

bash-3.2$ pip install geocodio Collecting geocodio Requirement already satisfied: Requests>=2.2.0 in ./anaconda/lib/python3.6/site-packages (from geocodio) Requirement already satisfied: idna<2.7,>=2.5 in ./anaconda/lib/python3.6/site-packages (from Requests>=2.2.0->geocodio) Requirement already satisfied: chardet<3.1.0,>=3.0.2 in ./anaconda/lib/python3.6/site-packages (from Requests>=2.2.0->geocodio) Requirement already satisfied: urllib3<1.23,>=1.21.1 in ./anaconda/lib/python3.6/site-packages (from Requests>=2.2.0->geocodio) Requirement already satisfied: certifi>=2017.4.17 in ./anaconda/lib/python3.6/site-packages (from Requests>=2.2.0->geocodio) Installing collected packages: geocodio Successfully installed geocodio-1.0.1

bash-3.2$ python3.6 Python 3.6.1 |Anaconda 4.4.0 (x86_64)| (default, May 11 2017, 13:04:09) [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)] on darwin Type "help", "copyright", "credits" or "license" for more information.

from geocodio import GeocodioClient Traceback (most recent call last): File "", line 1, in File "anaconda/lib/python3.6/site-packages/geocodio/init.py", line 8, in from client import Client ModuleNotFoundError: No module named 'client'

exit()

cat anaconda/lib/python3.6/site-packages/geocodio/init.py

!/usr/bin/env python
-*- coding: utf-8 -*-

__author__ = 'David Stanley'
__email__ = '[email protected]'
__version__ = '1.0.0'

from client import Client

__all__ = [Client]

bash-3.2$ head anaconda/lib/python3.6/site-packages/geocodio/client.py

import requests, json

class Client:
    url = 'http://api.geocod.io/v1'
    api_key = ''

    def __init__(self, api_key):
        """ Initialize the class, setting the api_key to the class property """
        self.api_key = api_key

Hopefully an easy question, but is it possible to get a separate value for LON/X AND LAT/Y from the geocoded_location.coords object?

We're testing how, using python, the output coordinates can be dumped into a PostGIS database and assembled into a geometry object.

Thanks!

The README example uses the coordinate (33.738987, -116.408) and mis-states the results in various places as '1600 Pennsylvania Ave, Washington, DC' or '100 Main St, Springfield, USA'

Someone needs to review the README pretty carefully. (I'm hoping that a careful proofing will also yield an answer to #9 )

"census" is one of the available fields: https://geocod.io/docs/#census-block-tract-amp-fips-codes, but calling client.geocode(address, fields=['census']) raises a ValueError ("census' is not a valid field value"). I fixed this locally by adding 'census' to ALLOWED_FIELDS on line 15 of client.py.