Test python asyncio-based code with ease.

TestAsyncCase.test_sync_async_add leaves the default loop closed. If TestAsyncCaseWithCustomLoop.test_await_async_add runs right after it, it will fail. As far as I can see from the other test methods, the default loop should be reset if it's closed.

Usually, this issue is masked by tests that run in between these two and re-set the default event loop as a side effect. It can be reproduced with pytest -k 'test_await_async_add or test_sync_async_add', or on Python 3.11 with #21 merged (cc @hroncok).

Using Mypy (at least in strict mode) with the library as it currently is causes errors.

import aiounittest


class ExampleTest(aiounittest.AsyncTestCase):
    def test_example(self) -> None:
        self.assertEqual(1, 2 - 1)

tests/test_example.py:4: error: Name "aiounittest.AsyncTestCase" is not defined
tests/test_example.py:4: error: Class cannot subclass "AsyncTestCase" (has type "Any")

It seems to be good practice to 're-export' (using __all__) all the things that you import into a module and wish to allow others to use as an import. I don't think this is actually functionally different, but just a convention. IDEs (auto-import feature) and Mypy pick up on this, at the very least.

Signed-off-by: Olivier Wilkinson (reivilibre) [email protected] I am happy for these changes to be available under the project's licence (MIT).

Hi :)

class Test(AsyncTestCase):
    @patch('some_path.features_topic.send', new=AsyncMock())
    async def test_smoke(self, mocked_topic):
        ...

I get a TypeError: test_smoke() missing 1 required positional argument: 'mocked_topic'

If I patch within the test with a with patch(..) as patched_object: it works fine.

When running multiple test cases using aiounittest under Python 3.8, the second and all the following unit test cases fail because there is no default event loop set in the MainThread. The following exception is raised when the unit tests are executed.

Traceback (most recent call last):
  File "lib\site-packages\aiounittest\helpers.py", line 130, in wrapper
    loop = get_brand_new_default_event_loop()
  File "lib\site-packages\aiounittest\helpers.py", line 117, in get_brand_new_default_event_loop
    old_loop = asyncio.get_event_loop()
  File "lib\asyncio\events.py", line 639, in get_event_loop
    raise RuntimeError('There is no current event loop in thread %r.'
RuntimeError: There is no current event loop in thread 'MainThread'.

This exception occurs because get_brand_new_default_event_loop tries to get the default event loop after it has been closed in the decorator.

The PyPI version does not check if a test case method is a coroutine, only that it is a callable. This differs from what's in this repo, which I think is the more correct behavior:

    def __getattribute__(self, name):
        attr = super().__getattribute__(name)
        if name.startswith('test_') and callable(attr):
            return async_test(attr, loop=self.get_event_loop())
        else:
            return attr

The AsyncTestCase assumes that only methods named test_* can be async, which isn't necessarily a valid assumption. This restriction should be removed, since you already test if the given function is a coroutine.

Can't call one test method directly:

$ python -m unittest my_test_module.MyTestCase.test_my_async_test
  File ".../unittest/loader.py", line 205, in loadTestsFromName
    test = obj()
TypeError: test_my_async_test() missing 1 required positional argument: 'self'

The reason is that the object given by __getattribute__ is tested against type.MethodType, but async_test(...) is not.

Fixes issue #10: RuntimeError was thrown the decorator trying to get the default event loop after the old event loop was closed. No default event loop existed and the asyncio threw a RuntimeErroe exception.

Right now mypy is not aware that aiounittest subclasses TestCase, which is a bummer for static typing. One has to

import aiounittest  # type: ignore

which gives it the Any type. Apart from disabling type checking, this also prevents us from turning on mypy --strict mode which includes disallow_subclassing_any = True or the following error ensues:

tests/test_case.py:15: error: Class cannot subclass 'AsyncTestCase' (has type 'Any')

It seems like we only need to add an empty py.typed marker file as described in https://www.python.org/dev/peps/pep-0561/

The bot created this issue to inform you that pyup.io has been set up on this repo. Once you have closed it, the bot will open pull requests for updates as soon as they are available.

Looks like latest pytest shows some warnings

============================================================================= warnings summary =============================================================================
tests/test_asynctestcase.py:41
  /home/tkloczko/rpmbuild/BUILD/aiounittest-1.4.1/tests/test_asynctestcase.py:41: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def test_yield_async_add(self):

tests/test_asynctestcase.py:56
  /home/tkloczko/rpmbuild/BUILD/aiounittest-1.4.1/tests/test_asynctestcase.py:56: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def test_yield_async_add(self):

tests/test_asynctestcase_get_event_loop.py:38
  /home/tkloczko/rpmbuild/BUILD/aiounittest-1.4.1/tests/test_asynctestcase_get_event_loop.py:38: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def test_yield_async_add(self):

-- Docs: https://docs.pytest.org/en/stable/warnings.html