Describe the bug When trying to launch a game I get this error

To Reproduce Use .join() on a root game place

Expected behavior Expected the game to start

Additional context I am using the Bleeding Edge version as the stable one had the error in the screenshot

This API only consists of /v1/router/signalr, and will only support Studio messages (I haven't found out what the main channel/main accessKey is for open grid servers)

Roblox endpoints that take in a single ID, like users.roblox.com/v1/users/{userId}, usually raise errors when the passed ID is invalid or does not exist. For example, /v1/users/{userId} returns the following data and a 404 error when an invalid user ID is passed:

{
  "errors": [
    {
      "code": 3,
      "message": "The user id is invalid.",
      "userFacingMessage": "Something went wrong"
    }
  ]
}

In ro.py, this means we can raise a NotFound error:

roblox.utilities.exceptions.NotFound: 404 Not Found: https://users.roblox.com/v1/users/4.

Errors:
	3: The user id is invalid.
		User-facing message: Something went wrong

Endpoints that take in multiple user IDs, like games.roblox.com/v1/games/multiget-place-details, tend to ignore invalid IDs and don't raise errors if none of the IDs are valid. In ro.py, all of our get_PLURAL functions like get_places and get_universes maintain this behavior and do not raise errors for invalid IDs.

The issue is that not all of our get_SINGULAR functions use endpoints that only take in one ID. multiget-place-details is the only endpoint ro.py uses for places. Because it does not raise an error, get_place returns None if the place is invalid and doesn't raise an exception. Multiple other methods also have this behavior.

This causes an inconsistency between methods where some methods (the ones that send requests that take just one ID) raise errors with invalid inputs, but other methods (the ones that take multiple IDs but only pass one) don't raise errors.

The following Client methods all return None with invalid IDs:

get_user_by_username()
get_universe()
get_place()
get_plugin()

All other singular methods raise exceptions for invalid IDs. This causes an inconsistency between methods. What should we do?

We have a couple options here:

• Make the other methods also return None instead of raising exceptions
  • Not only is this a large breaking change, but it's also not proper when compared to API responses which do raise errors. I feel better about raising errors manually than I do about replacing the API's error behavior.
• Raise fake NotFound errors on these methods in particular
  • I don't like this because we're only supposed to raise NotFound for actual 404 errors.
• Create custom errors, like UserNotFound that are raised in place of NotFound on get_user and get_user_by_username, and do the same for other methods
  • This means you can't do a try-except for NotFound on get_user anymore, which is breaking.
  • Making it a subclass of HTTPException kind of breaks the rules because it's really only for 4xx/5xx HTTP status codes, not for other purposes.
  • Making it a subclass of RobloxException means we're not raising the right exception for get_user anymore. That's an actual HTTP exception, so I think we should keep that there.
  • Only raising it for get_user_by_username and not get_user is a bit weird for the developer because there's an exception called UserNotFound that isn't raised on the method used to get users but is raised on the method used to get users by username.
• Live with the inconsistencies.
  • Obviously not ideal. 😔
• Completely get rid of get_user_by_username, get_universe, get_place and get_plugin and force developers to use their plural counterparts: get_users_by_username, get_universes, get_places and get_plugins.
  • This makes the methods consistent now but breaks existing code and is not really ideal.

There is an issue with production right now, there is little to no strong typing on anything.

All implementations for the rewrite should be strong typed, as it is supported.

The benefits of this include stronger intellisense.

If you look at my libraries they show strong typed code, with predicable interfaces, it is preferable to do this because it is more convenient than having to go to some documentation page.

You can disregard this issue if you wish, but take it into mind.

So when I try to install the latest version using the readme as a guide, I get an exit code of 128 and am unable to install.

  Cloning git://github.com/ro-py/ro.py.git to c:\users\willy\appdata\local\temp\pip-req-build-6sxtv1nh
  Running command git clone --filter=blob:none --quiet git://github.com/ro-py/ro.py.git 'C:\Users\###\AppData\Local\Temp\pip-req-build-6sxtv1nh'
  fatal: unable to connect to github.com:
  github.com[0: 140.82.113.4]: errno=Unknown error

  error: subprocess-exited-with-error

  × git clone --filter=blob:none --quiet git://github.com/ro-py/ro.py.git 'C:\Users\###\AppData\Local\Temp\pip-req-build-6sxtv1nh' did not run successfully.
  │ exit code: 128
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× git clone --filter=blob:none --quiet git://github.com/ro-py/ro.py.git 'C:\Users\###\AppData\Local\Temp\pip-req-build-6sxtv1nh' did not run successfully.
│ exit code: 128
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.```

Describe the bug When calling group.get_member(id), the following error is thrown:

To Reproduce Call .get_member(id) on a group object.

Expected behaviour Expected the call to not error and return a Member object.

Additional context A request to https://groups.roblox.com/v2/users/{userId}/groups/roles is sent, and passed on to Member. It will attempt to index the user key on the data, which errors because the endpoint does not return that data.

Before, get_member_by_id would error with a NotFound since it was trying to compare a string and an int. This just adds an int() to convert the group id to an int, which is what the response is.

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] NO If your feature is related to implementing a new Roblox API, provide information here. API URL: https://users.roblox.com/v1/users/{userId} Documented: Yes/No no

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. It would be cool if we could check a user's inventory for checking gamepasses or asset's and then from there, ranking them in your group. Additional context Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

If your feature is related to implementing a new Roblox API, provide information here. API URL: https://users.roblox.com/v1/users/{userId} Documented: Yes/No

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Improving the docs would improve developers workflow and code efficiency which would result in lower amount of requests aswell.

My suggestion on how to improve docs:

• Add ~40px space or a separator between each method so its visible what belongs where
• Remove unnecessary source code snippets and replace them with code examples (on the methods which might sound confusing)
• Remove unnecessary init constructors found at some methods
• Make an examples tab

The Python 3.7 feature "Dataclasses" could be very useful for ro.py. Our objects, like User, should be immutable as the only way to return new information is generating a new object entirely. https://docs.python.org/3.9/library/dataclasses.html

Changes:

• Added has_verified_badge to User
• Added has_verified_badge to PartialUser
• Added has_verified_badge to Group
• Added has_verified_badge to UniversePartialGroup
• Added has_verified_badge to AssetPartialGroup
• Added has_verified_badge to Place
• Added has_verified_badge to Member

Add group_search to client.

E.g:

 async for group in client.group_search("roblox").items(10):
    print(group.name)

Returns:

Roblox
Roblox High School: Fan Club
RODNY ROBLOX
Roblox Wiki
Studios Military Roleplay Fan Roblox Clothing
LankyBox Roblox Group!
Roblox+
Roblox Military Building Roleplaying Community
Robloxian High School Group
Roblox catalog Group fan

Fixes links to the Bases page for every get_base_XYZ method documentation and clarifies that get_base_XYZ is not asynchronous and does not need to be awaited in bases.md

Is your feature request related to a problem? Please describe. Yes, I wanted to customise timeouts but I didn't have a way so I wrote spaghetti code :=)

If your feature is related to implementing a new Roblox API, provide information here. API URL: none Documented: none

Describe the solution you'd like Add an option to pass your own requests class into the client

Describe alternatives you've considered None

Additional context

session = httpx.Session(timeout=10)
requests = Requests(
    url_generator=None,
    session=session
)
client = Client(requests=requests)