If a user has spatial filter(s) set, would be good to be able to (optionally) see the borders of the filters on the map.

IMO ideally they wouldn't appear as layers, but maybe more like a decoration (ie: layout extents, grids, etc)? Maybe @hamishcampbell has other ideas?

The plugin currently fails to recognize SSH paths to hosted repositories.

This change moves the responsibility for determining the users intended clone source into the clone widget. This also fixes handling of paths already prefixed with file:// and tightens up the checking of http/https paths.

• [x] Issue template — make sure we're getting the right info/OS/versions/logs/context/etc to help figure issues out quickly.
• [x] Contributing doc — how to get up and running with the plugin for development (as opposed to "install from here"), conventions, etc.

The plugin should robustly handle the case of Kart not installed or misconfigured.

Eventually, it might perform installation itself, so they user can do the full setup from QGIS

Minor UI changes (mostly wording) rollup issue

• [x] Working tree → Working copy everywhere

• [x] heading → “Your Kart installation location is not configured:”
• [x] stray "."

• [x] pane titlebar → "Kart Repositories"

• [x] hint text → "Tip: right-click on items for available actions"

• [x] remove logo/heading (~ideally move logo to pane title~ not a thing)

• [x] add a space between repo title & branch name

• [x] can we collapse the repository path in the middle when the panel isn't wide enough and the repo doesn't have a title set? I think Qt supports this via elidedText. ie:

  /Users/rcoup/code/kart-foss4g-2021/workshop/first [mybranch]  # now
  ~/code/kart-foss4g-2021/workshop/first [mybranch]             # use ~ for os.path.expanduser('~') prefix
  ~/code/.../workshop/first [mybranch]                          # collapse in the middle
  

• [x] Remove this repository: icon → minus-circle-outline
• [x] Show log: icon → history
• [x] Show working tree changes: icon → compare
• [x] Discard working tree changes: icon → undo
• [x] Commit working tree changes: icon → content-save-outline
• [x] Switch branch: icon → swap-horizontal
• [x] Apply patch: icon → file-import-outline
• [x] Menu order/wording
  • -break-
  • Show log...
  • Show working copy changes...
  • Discard working copy changes
  • Commit working copy changes...
  • Switch branch...
  • Merge into {current-branch}...
  • -break-
  • Pull...
  • Push...
  • -break-
  • Import layer to repository...
  • Apply patch...
  • -break-
  • Refresh
  • Properties...
  • Remove this repository

• [x] Matching icon and wording changes from the repository context menu
• [x] Menu ordering:
  • Add to QGIS project
  • -break-
  • Show log...
  • Show working copy changes for dataset...
  • Discard working copy changes for dataset
  • Commit working copy changes for dataset...
  • -break-
  • Remove from repository

Diff Viewer dialog

• [x] Restore old version
• [x] Restore new version
• [x] Don't show restore new version when displaying working-tree changes
• [x] Project layers should be the default for "additional layers"
• [x] Map extent needs some padding so vertices don't end up drawn on the edges of the map
• [x] Swipe cursor should change from hand to resize when the mouse hovers over the black line
• [x] ~Scrolling to zoom seems really rough~ nevermind, is my machine
• [x] [status message] Working copy has been updated.

Layer context menu

• [x] ~Can we add the Kart icon to make it stand out a bit in the menu?~
• [x] Wording/icons need to match the other menus

@hamishcampbell @rcoup Not sure how this is done in Kart, since I could not find a command for it.

Should the plugin just delete the table in the repo database and then commit?

Hi!

Firstable, contragratulations for the plugin! Its a great contribution for the QGIS users community.

I´m testing the plugin guided by documentation, and when I use the create new repository option, QGIS report me the error message "The specified folder already exists"

The folder is empty and I don't "init" it before.

Meanwhile, if I create a new repository with command terminal and add it using the Kart plugin there isn´t any problem.

This is the information about by environment.

Kart Plugin version 1.0.1 QGIS version 3.20.2-Odense Operating system Windows 10 10.0.19041 Kart version Kart v0.10.7, Copyright (c) Kart Contributors » GDAL v3.3.2; PROJ v8.1.1 » PyGit2 v1.7.0; Libgit2 v1.3.0; Git v2.29.2.windows.1 » SQLAlchemy v1.4.11; pysqlite3 v2.6.0/v3.31.1; SpatiaLite v5.0.0; Libpq v11.0.9 » SpatialIndex v1.9.3

Thx

Entirely possible I'm missing something obvious here, but I just tried installing the QGIS Kart plugin, and I'm getting the following error in the Python error log when going to Plugins -> Kart -> About....

2021-12-20T11:37:56     WARNING    Traceback (most recent call last):
              File "/Users/leighhunt/Library/Application Support/QGIS/QGIS3/profiles/default/python/plugins/kart/plugin.py", line 72, in openAbout
              pluginVersion = self.pluginVersion()
              File "/Users/leighhunt/Library/Application Support/QGIS/QGIS3/profiles/default/python/plugins/kart/plugin.py", line 66, in pluginVersion
              config.read(path)
              File "/Applications/QGIS.app/Contents/MacOS/../Resources/python/configparser.py", line 697, in read
              self._read(fp, filename)
              File "/Applications/QGIS.app/Contents/MacOS/../Resources/python/configparser.py", line 1017, in _read
              for lineno, line in enumerate(fp, start=1):
              File "/Applications/QGIS.app/Contents/MacOS/lib/python3.8/encodings/ascii.py", line 26, in decode
              return codecs.ascii_decode(input, self.errors)[0]
             UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 591: ordinal not in range(128)

I then went to Plugins -> Kart -> Settings... and set Kart executable to /usr/local/bin/kart and get the following error in the Kart log:

2021-12-20T11:38:01     INFO    Command: Applications/Kart.app/Contents/MacOS/kart_cli --version
2021-12-20T11:38:01     CRITICAL    [Errno 2] No such file or directory: 'Applications/Kart.app/Contents/MacOS/kart_cli'

Further info:

QGIS Plugins log:

2021-12-20T11:44:50     INFO    Loaded QuickMapServices (package: quick_map_services)
2021-12-20T11:44:51     INFO    Loaded Relief Visualization Toolbox (package: rvt-qgis)
2021-12-20T11:44:53     INFO    Loaded Processing (package: processing)
2021-12-20T11:44:53     INFO    Loaded DB Manager (package: db_manager)
2021-12-20T11:44:53     INFO    Loaded MetaSearch Catalog Client (package: MetaSearch)
2021-12-20T11:45:09     INFO    Loaded Kart (package: kart)

which kart
/usr/local/bin/kart

kart --version
Kart v0.10.7, Copyright (c) Kart Contributors
» GDAL v3.3.2; PROJ v6.3.0
» PyGit2 v1.7.0; Libgit2 v1.3.0; Git v2.33.GIT
» SQLAlchemy v1.4.11; pysqlite3 v2.6.0/v3.31.1; SpatiaLite v5.0.1; Libpq v14.0.1
» SpatialIndex v1.9.3

kart_cli
zsh: command not found: kart_cli

Kart was installed using homebrew, OS: MacOSX Monterey, on MacBook Air with M1 chip. QGIS version 3.18.1-Zürich

More verbose error message when attempting to see Kart Settings again:

An error has occurred while executing Python code: 

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 591: ordinal not in range(128) 
Traceback (most recent call last):
  File "/Users/leighhunt/Library/Application Support/QGIS/QGIS3/profiles/default/python/plugins/kart/plugin.py", line 72, in openAbout
    pluginVersion = self.pluginVersion()
  File "/Users/leighhunt/Library/Application Support/QGIS/QGIS3/profiles/default/python/plugins/kart/plugin.py", line 66, in pluginVersion
    config.read(path)
  File "/Applications/QGIS.app/Contents/MacOS/../Resources/python/configparser.py", line 697, in read
    self._read(fp, filename)
  File "/Applications/QGIS.app/Contents/MacOS/../Resources/python/configparser.py", line 1017, in _read
    for lineno, line in enumerate(fp, start=1):
  File "/Applications/QGIS.app/Contents/MacOS/lib/python3.8/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 591: ordinal not in range(128)


Python version: 3.8.7 (default, Feb 10 2021, 09:04:08) [Clang 12.0.0 (clang-1200.0.32.29)] 
QGIS version: 3.18.1-Zürich Zürich, 202f1bf7e5 

Python Path:
/Applications/QGIS.app/Contents/MacOS/../Resources/python
/Users/leighhunt/Library/Application Support/QGIS/QGIS3/profiles/default/python
/Users/leighhunt/Library/Application Support/QGIS/QGIS3/profiles/default/python/plugins
/Applications/QGIS.app/Contents/MacOS/../Resources/python/plugins
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/patsy-0.5.1-py3.8.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/Rtree-0.9.4-py3.8.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/geopandas-0.8.1-py3.8.egg
/Applications/QGIS.app/Contents/MacOS/lib/python38.zip
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/rasterio-1.1.5-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/Fiona-1.8.13.post1-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/click_plugins-1.1.1-py3.8.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/numpy-1.20.1-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/affine-2.3.0-py3.8.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/pandas-1.1.0-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/netCDF4-1.5.4-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/statsmodels-0.11.1-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/lib-dynload
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/cftime-1.2.1-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/pyproj-2.6.0-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/scipy-1.5.1-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/Pillow-7.2.0-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/numba-0.50.1-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/snuggs-1.4.7-py3.8.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/GDAL-3.2.1-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/matplotlib-3.3.0-py3.8-macosx-10.13.0-x86_64.egg
/Applications/QGIS.app/Contents/MacOS/lib/python3.8/site-packages/opencv_contrib_python-4.3.0.36-py3.8-macosx-10.13.0-x86_64.egg
/Users/leighhunt/Library/Application Support/QGIS/QGIS3/profiles/default/python
/Users/leighhunt/Library/Application Support/QGIS/QGIS3/profiles/default/python/plugins/rvt-qgis
/Users/leighhunt/dev/playground/covid/covid-geojson

When I enter in...

Show Logs > Show changes introduced by this commit...

the following error is displayed

An error has occurred while executing Python code:

ValueError: too many values to unpack (expected 2) Traceback (most recent call last): File "C:\Users/UTEA/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\kart\gui\diffviewer.py", line 182, in treeItemChanged self._createLayers() File "C:\Users/UTEA/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\kart\gui\diffviewer.py", line 458, in _createLayers self._createFeatureDiffLayers() File "C:\Users/UTEA/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\kart\gui\diffviewer.py", line 513, in _createFeatureDiffLayers self._createVertexDiffLayer(geoms) File "C:\Users/UTEA/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\kart\gui\diffviewer.py", line 557, in _createVertexDiffLayer x, y = coord.strip().split(" ") ValueError: too many values to unpack (expected 2)

I work with QGIS 3.22.10 and Kart 0.11.3

Thank you!

Describe the bug I have imported datasets into my repository (a localhost postgis working copy), using both the command line and the plugin, but I can't load it into QGIS using the Add to QGIS project option.

2022-05-04T01:44:23 WARNING Traceback (most recent call last): File "C:\Users/testing/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\kart\gui\dockwidget.py", line 158, in wrapper f(*args) File "C:\Users/testing/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\kart\gui\dockwidget.py", line 734, in addToProject layer = self.repo.workingCopyLayer(self.name) File "C:\Users/testing/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\kart\kartapi.py", line 738, in workingCopyLayer uri.setConnection(host, port, database) TypeError: QgsDataSourceUri.setConnection(): arguments did not match any overloaded call: overload 1: not enough arguments overload 2: not enough arguments

I am using a Windows 10 virtual machine, with QGIS 3.22.6 and PostgreSQL 13.6 Postgis 3.1

I am able to load the layers manually, though.

The same type of error appears when I try to show changes on the working copy dataset. I am able to see the attributes changes, but the geometries changes appear empty and a similar error is shown.

Version info (this is important!):

• Operating System (e.g. Windows 10, macOS): Windows 10

Kart Plugin version 1.0.2 QGIS version 3.22.6-Białowieża Operating system Windows 10 10.0.19044 Kart version Kart v0.11.1, Copyright (c) Kart Contributors » GDAL v3.3.2; PROJ v8.1.1 » PyGit2 v1.9.0; Libgit2 v1.4.2; Git v2.34.0.windows.1.13.g93318cbc8d » SQLAlchemy v1.4.29; pysqlite3 v2.6.0/v3.31.1; SpatiaLite v5.0.0; Libpq v11.0.9 » SpatialIndex v1.9.3

Paste the contents from "Plugins...Kart...About Kart" into here

Describe the bug Plugin doesn't load.

To Reproduce Steps to reproduce the behavior:

1. Open Plugin Manager
2. Find Kart plugin and attempt to install
3. Get error: Couldn't load plugin 'kart' due to an error when calling its classFactory() method, ModuleNotFoundError: No module named 'mock' (full error below)
4. Install from zip instead
5. Close & re-open QGIS
6. On QGIS start, same error

Expected behavior I expected the plugin to install & open without error.

Version info (this is important!):

• Operating System (e.g. Windows 10, macOS): Ubuntu 20.04
• QGIS, Kart & Plugin details:
  • Kart v0.10.7
  • QGIS version: 3.22.1

Additional context Full error message:

Couldn't load plugin 'kart' due to an error when calling its classFactory() method 

ModuleNotFoundError: No module named 'mock' 
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/qgis/utils.py", line 423, in _startPlugin
    plugins[packageName] = package.classFactory(iface)
  File "/home/john/.local/share/QGIS/QGIS3/profiles/default/python/plugins/kart/__init__.py", line 2, in classFactory
    from kart.plugin import KartPlugin
  File "/usr/lib/python3/dist-packages/qgis/utils.py", line 888, in _import
    mod = _builtin_import(name, globals, locals, fromlist, level)
  File "/home/john/.local/share/QGIS/QGIS3/profiles/default/python/plugins/kart/plugin.py", line 11, in 
    from kart.gui.dockwidget import KartDockWidget
  File "/usr/lib/python3/dist-packages/qgis/utils.py", line 888, in _import
    mod = _builtin_import(name, globals, locals, fromlist, level)
  File "/home/john/.local/share/QGIS/QGIS3/profiles/default/python/plugins/kart/gui/dockwidget.py", line 27, in 
    from kart.kartapi import (
  File "/usr/lib/python3/dist-packages/qgis/utils.py", line 888, in _import
    mod = _builtin_import(name, globals, locals, fromlist, level)
  File "/home/john/.local/share/QGIS/QGIS3/profiles/default/python/plugins/kart/kartapi.py", line 31, in 
    from kart.gui.installationwarningdialog import InstallationWarningDialog
  File "/usr/lib/python3/dist-packages/qgis/utils.py", line 888, in _import
    mod = _builtin_import(name, globals, locals, fromlist, level)
  File "/home/john/.local/share/QGIS/QGIS3/profiles/default/python/plugins/kart/gui/installationwarningdialog.py", line 13, in 
    from kart.gui.settingsdialog import SettingsDialog
  File "/usr/lib/python3/dist-packages/qgis/utils.py", line 888, in _import
    mod = _builtin_import(name, globals, locals, fromlist, level)
  File "/home/john/.local/share/QGIS/QGIS3/profiles/default/python/plugins/kart/gui/settingsdialog.py", line 9, in 
    from kart.utils import setting, setSetting, KARTPATH, AUTOCOMMIT, DIFFSTYLES
  File "/usr/lib/python3/dist-packages/qgis/utils.py", line 888, in _import
    mod = _builtin_import(name, globals, locals, fromlist, level)
  File "/home/john/.local/share/QGIS/QGIS3/profiles/default/python/plugins/kart/utils.py", line 7, in 
    from qgis.testing.mocked import get_iface
  File "/usr/lib/python3/dist-packages/qgis/utils.py", line 888, in _import
    mod = _builtin_import(name, globals, locals, fromlist, level)
  File "/usr/lib/python3/dist-packages/qgis/testing/mocked.py", line 26, in 
    import mock
  File "/usr/lib/python3/dist-packages/qgis/utils.py", line 888, in _import
    mod = _builtin_import(name, globals, locals, fromlist, level)
ModuleNotFoundError: No module named 'mock'


Python version: 3.8.10 (default, Nov 26 2021, 20:14:08) [GCC 9.3.0] 
QGIS version: 3.22.1-Białowieża Białowieża, 663dcf8fb9 

Python Path:
/usr/share/python-wheels/chardet-3.0.4-py2.py3-none-any.whl
/usr/share/python-wheels/requests-2.22.0-py2.py3-none-any.whl
/usr/share/python-wheels/colorama-0.4.3-py2.py3-none-any.whl
/usr/share/python-wheels/html5lib-1.0.1-py2.py3-none-any.whl
/usr/share/python-wheels/toml-0.10.0-py2.py3-none-any.whl
/usr/share/python-wheels/lockfile-0.12.2-py2.py3-none-any.whl
/usr/share/python-wheels/setuptools-44.0.0-py2.py3-none-any.whl
/usr/share/python-wheels/progress-1.5-py2.py3-none-any.whl
/usr/share/python-wheels/packaging-20.3-py2.py3-none-any.whl
/usr/share/python-wheels/retrying-1.3.3-py2.py3-none-any.whl
/usr/share/python-wheels/idna-2.8-py2.py3-none-any.whl
/usr/share/python-wheels/wheel-0.34.2-py2.py3-none-any.whl
/usr/share/python-wheels/six-1.14.0-py2.py3-none-any.whl
/usr/share/python-wheels/webencodings-0.5.1-py2.py3-none-any.whl
/usr/share/python-wheels/distlib-0.3.0-py2.py3-none-any.whl
/usr/share/python-wheels/msgpack-0.6.2-py2.py3-none-any.whl
/usr/share/python-wheels/ipaddr-2.2.0-py2.py3-none-any.whl
/usr/share/python-wheels/pyparsing-2.4.6-py2.py3-none-any.whl
/usr/share/python-wheels/distro-1.4.0-py2.py3-none-any.whl
/usr/share/python-wheels/pip-20.0.2-py2.py3-none-any.whl
/usr/share/python-wheels/contextlib2-0.6.0-py2.py3-none-any.whl
/usr/share/python-wheels/CacheControl-0.12.6-py2.py3-none-any.whl
/usr/share/python-wheels/urllib3-1.25.8-py2.py3-none-any.whl
/usr/share/python-wheels/certifi-2019.11.28-py2.py3-none-any.whl
/usr/share/python-wheels/pep517-0.8.2-py2.py3-none-any.whl
/usr/share/python-wheels/pkg_resources-0.0.0-py2.py3-none-any.whl
/usr/share/python-wheels/appdirs-1.4.3-py2.py3-none-any.whl
/usr/share/qgis/python
/home/john/.local/share/QGIS/QGIS3/profiles/default/python
/home/john/.local/share/QGIS/QGIS3/profiles/default/python/plugins
/usr/share/qgis/python/plugins
/usr/lib/python38.zip
/usr/lib/python3.8
/usr/lib/python3.8/lib-dynload
/usr/local/lib/python3.8/dist-packages
/usr/lib/python3/dist-packages
/home/john/.local/share/QGIS/QGIS3/profiles/default/python

Is your feature request related to a problem? Please describe.

The only place you can create a branch is from within the Repo Log window by right clicking a particular commit to branch from. This is a bit obscure and I would expect to be able to create a branch from the right click menu of the Repo itself, and possibly from within the "Switch Branch" dialog.

Usually you want to create a branch from the current state of the Repository, so going into the Log shouldn't really be necessary for most use cases.

Describe the solution you'd like

Add a "create branch" option to the right click context menu for a Repository (or similar option).

It seems that Kart uses UTC for storing all operations (good), however when using history in the plugin depending on the time of the day it will set filter to local machine time which would hide the graph nodes. My timezone is UTC-6 I added some data and I thought it was empty but when expanding the search for the 8th the graph is there, do not know an easy way to handle this but for new people it may be confusing, and I don't know if this is mentioned in the documentation

if the kart repository already includes a layer that happens to have the same name as one you are importing the plugin shows only there is conflict but no way to handle it, ideally it would allow user to specify a non-conflicting name if wanted or cancel the operations

Steps:

1. Add a layer to the dataset from any source for example 'airportheliport'
2. Load a GPKG that also has a source 'airportheliport'

Describe the bug If there are more than one layers from Kart repos on a map and "Activate 'show feature history' map tool" is selected on a layer which is not the top most feature history from that layer will always be used even if features from other layers are 'in front' of that chosen layer.

Expected behavior Not sure as the choice was explicit but the end result is at best non obvious, particularly if the layers are from the same 'Author'. Potentially it should highlight the selected feature as per 'select features' QGIS command.

Screenshots

Version info (this is important!):

• Operating System (e.g. Windows 10, macOS): MacOS
• QGIS, Kart & Plugin details: QGIS 3.28 Kart plugin 1.0.4

Kart Plugin version
1.0.4
QGIS version
3.28.0-Firenze
Operating system
macOS 13.0 x86_64 i386 64bit
Kart version
Kart v0.11.5, Copyright (c) Kart Contributors
» GDAL v3.4.0; PROJ v6.3.0
» PyGit2 v1.9.0; Libgit2 v1.4.2; Git v2.33.GIT
» SQLAlchemy v1.4.40; pysqlite3 v2.6.0/v3.31.1; SpatiaLite v5.0.1; Libpq v14.0.5
» SpatialIndex v1.9.3

Import a GPKG with more than one layer the following popup shows but there is no option to select which table, so it seems only single layer GPKG are supported

Ideally when adding a GPKG with multiple tables a user would be able to select all the tables that they want imported to keep track off

As a sample the world_map.gpkg shipped with QGIS may be used