Do not merge it yet, I have not tested it.

But with this PR you'll be able to select two new places (position of bait and position of equip button for bait confirmation).

After repairing it'll automatically select bait (so it has the same timer as repair!)

This implements several improvements found in other PRs on this repository. I also took it upon myself to refactor the bot to use Asyncio to juggle tasks on the backend and threading to seperate the GUI from said backend. This means no issues with locked GUI.

I refactored out a lot of the really egregious design decisions up to a certain point and did a half assed job merging and removing a lot of unnecessary bloat. Theres still a LOT of room for improvement too now that the CV is running on asyncio too. I'm sure I'll eventually add it but this is what I felt like doing tonight.

Edit: To clairfy, this also integrates the following active PRs as well: https://github.com/Siterizer/new-world-fishing-bot/pull/208 https://github.com/Siterizer/new-world-fishing-bot/pull/164 https://github.com/Siterizer/new-world-fishing-bot/pull/134 https://github.com/Siterizer/new-world-fishing-bot/pull/106

I did test 1.2.1 version, new world kicking me with login blocked notification. But was very well running 8-9 hours. I'm reporting this for users to be careful #135

Iterating through a Python array with two nested for-loops is not as fast as openCV/Numpy can do it vectorized. Therefore, I replaced the two for-loops by the OpenCV function cv::inRange() and the python array given by PIL with a numpy one.

I tried my best measuring the improvements with measuring the execution time of call_appropriate_fishing_action():

Before: ~0,3534 seconds After: ~0,09526 seconds == 3,71 times faster (median average bit smaller: 3,62)

Just the color finding part without template matching is ~175 - 200 times faster.

Another Upside: we now have all the color matching pixels and could do some math on them to get the area, e.g. for optimized reeling (all white pixels in mask).

Ran the bot anywhere from 5 minutes to 5 hours. I have no way of knowing, i was away from PC for 5 hours, and when i came back this was on screen. I have no other software running that would be detected as malicious.

Edit: Its worth noting: i did not use the EXE, i cloned the code and ran it via CMD. I also made my own anti AFK module before it was released to this github.

Weirdly enough i am not banned, even though the kick states it found "Suspicious Software"...

I would say use it at own risk? But then again, they dont seem to be banning for it. Maybe you gotta get kicked a certain amount of times for this "offense" before they ban you.

Edit2: Just wanted to mention also: I find it very unlikely that i got reported by somebody. I was fishing at a very unpopulated spot, and it was from 7am to 12pm on a monday. My server barely has anybody playing at those times.

Sometimes the catch will bug at 0.0m and will never actually be caught, the tension display was orange during this and I had to manually hold LMB to purposefully break the line for fishing to be able to continue. Obviously this is a New World bug but could be mitigated within the bot, perhaps just check if we've paused on orange for X number of seconds assume it's bugged and just hold LMB until the line snaps.

The bot finds the fish, pulls it a little and then stops, until it completely loses the fish ... Once lost, it starts again and then does the same thing. Otherwise, the auto repair works well.

Hello, as of today, when I entered the game, I encountered this, I was not in the game when I was banned, I guess my game ends here, I will never use it again after the ban is lifted. I'm sorry I'm using translation

Time between catching a fish and casting again is too long. You can skip the animation that occurs once you've caught a fish by left clicking once. Then the wait time can be decreased as well before the next cast.

"Free look" works differently, now you need to hold down the button. Reset key bindings to default and assign 'B' not work. Everything worked fine for a week.

When obtaining fish, animation is being played, but it can be skipped with left click almost immediately. Adding such a feature will lead to significant increase of efficiency (each animation takes about 6 seconds to end). Is it possible to upgrade the bot this way?

I'm waiting build, can't reproduce environment to assemble by myself.
Can you add a dockerfile to build? pip install -r requirements.txt throw err i have no python practice release a new version please