zipkin-server log: Cannot decode spans due to IllegalArgumentException(Error reading List from TBinary)

when i modify like this ,it works. 39 40 def default_handler(self, encoded_span): 41 try: 42 #body = str.encode('\x0c\x00\x00\x00\x01') + encoded_span 43 body = encoded_span

This decorator aims to make easier people creating child span. Normally we have to create a span resource everytime we want to create a child span. For example:

def some_method():
    with zipkin_span(service_name='example', span_name='some_method') as z:
        result = do_something()
        z.update_binary_annotations({'result': result})

Using this decorator we can do this instead:

@flask_zipkin.child_span
def some_method(*args, **kwargs):
    result = do_something()
    kwargs['span'].update_binary_annotations({'result': result})  

The decorated method will use flask application name as service_name and the decorated method name as span_name.

when i modify like this ,it works. 39 40 def default_handler(self, encoded_span): 41 try: 42 #body = str.encode('\x0c\x00\x00\x00\x01') + encoded_span 43 body = encoded_span

repeat problem #17

Hi. I follow the instruction here but I have an error. TypeError: default_handler() missing 1 required positional argument: 'encoded_span'

I think this is because I may lose the span for the entry service. But I actually added it. My code is as below:

@zipkin.transport_handler def default_handler(self, encoded_span): body = str.encode('\x0c\x00\x00\x00\x01') + encoded_span return requests.post( 'http://144.173.55.61:9411/api/v1/spans', data=body, headers={'Content-Type': 'application/x-thrift'},)

#index #@zipkin_span(service_name='my_service', span_name='index',transport_handler=default_handler, sample_rate=100) @app.route('/') def index(): with zipkin_span( service_name='webapp', span_name='index', transport_handler=default_handler, port=9411, sample_rate=100, #0.05, # Value between 0.0 and 100.0 ): return render_template('home.html')

Could you please help me with it?

Here is my code server: https://onlinegdb.com/r1gZ6lnFH

After curl localhost:8080 the console show: call zipkin transport_handler code = 400, text = Expected value at line 1 column 1 path $ reading List from json , reason = Bad Request

How can i Fixed it. Thanks you

even though http headers are supposed to be case-insensitive, this "Parentspanid" header as capitalized previously was failing to be picked up by downstream instrumentations. if nothing else, good for consistency

It is possible that zipkin.logging is called before request actually has been made -- in unit tests, for example (with app.test_request_context() does not run before/after request hooks).

Seeing errors like

  def _after_request(self, response):
        if self._disable:
            return response
        if not hasattr(g, '_zipkin_span'):
            return response
        g._zipkin_span.stop()
        return response
    def create_http_headers_for_new_span(self):
        if self._disable:
            return dict()

    'b6dbb1c2b362bf51' => -5270423489115668655
:param hex_string: the string representation of a zipkin ID
:returns: signed int representation
"""
return struct.unpack('q', struct.pack('Q', int(hex_string, 16)))[0]

def signed_int_to_unsigned_hex(signed_int): """Converts a signed int value to a 64-bit hex string.

There is a small typo in README.md.

Should read receive rather than recieve.

Semi-automated pull request generated by https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

In function "_safe_header", it has the following logic:

def _safe_headers(self, headers):
    if hasattr(self, "_headers"):
        return self._headers
    self._headers = dict((k.lower(), v) for k, v in headers.__iter__())
    return self._headers

If the 1st request contains "X-B3*" headers, it will assign to self._headers. Then for every inbound request after that, it reuse the _headers based on the 1st request instead of parsing from the new header. This will cause all the newly created spans are chained with the 1st trace id. Therefore for any python app which is in the middle of any process, the zipkin tracing could be incorrect.

I am not sure if this is an actual bug, or I implemented in a wrong way which caused this issue. Please have a review, I would love to hear your reply on this.

Hi,

In the README.md file, there is one part of tutorial is updating the tags to the span (zipkin.update_tags(id=1, user_id=2)). I tried this in two different approach and both returns me errors.

1, AttributeError: 'ZipkinLoggingContext' object has no attribute 'binary_annotations_dict'

I encountered this error while I put the "update_tags" inside the route function as below (function name "index").

from flask import Flask
from flask_zipkin import Zipkin
import requests

app = Flask(__name__)
app.config['ZIPKIN_DISABLE'] = False
app.config['ZIPKIN_DSN'] = "<url>"
zipkin = Zipkin(app)

@app.route('/')
def index():
    headers = {}
    headers.update(zipkin.create_http_headers_for_new_span())
    zipkin.update_tags(id=1, user_id=2)
    r = requests.get('<url>', headers=headers)
    return r.text, 200

# Start the app server
if __name__ == '__main__':
    app.run(debug=True, host='127.0.0.1', threaded=True)

-----------------------------------------------

Traceback (most recent call last):
  File "C:\<path>\venv\lib\site-packages\flask\app.py", line 2091, in __call__
    return self.wsgi_app(environ, start_response)
  File "C:\<path>\venv\lib\site-packages\flask\app.py", line 2076, in wsgi_app
    response = self.handle_exception(e)
  File "C:\<path>\venv\lib\site-packages\flask\app.py", line 2073, in wsgi_app
    response = self.full_dispatch_request()
  File "C:\<path>\venv\lib\site-packages\flask\app.py", line 1518, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "C:\<path>\venv\lib\site-packages\flask\app.py", line 1516, in full_dispatch_request
    rv = self.dispatch_request()
  File "C:\<path>\venv\lib\site-packages\flask\app.py", line 1502, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
  File "C:\<path>\flask-zipkin-test.py", line 26, in index
    zipkin.update_tags(id=1, user_id=2)
  File "C:\<path>\venv\lib\site-packages\flask_zipkin.py", line 152, in update_tags
    g._zipkin_span.logging_context.binary_annotations_dict.update(
AttributeError: 'ZipkinLoggingContext' object has no attribute 'binary_annotations_dict'

2, RuntimeError: Working outside of application context.

This error is triggered if I put the "update_tag" function right after initialize Zipkin object.

from flask import Flask
from flask_zipkin import Zipkin
import requests

app = Flask(__name__)
app.config['ZIPKIN_DISABLE'] = False
app.config['ZIPKIN_DSN'] = "<URL>"
zipkin = Zipkin(app)
zipkin.update_tags(id=1, user_id=2)

@app.route('/')
def index():
    headers = {}
    headers.update(zipkin.create_http_headers_for_new_span())
    r = requests.get('<URL>', headers=headers)
    return r.text, 200

# Start the app server
if __name__ == '__main__':
    app.run(debug=True, host='127.0.0.1', threaded=True)

---------------------------------------------------

Traceback (most recent call last):
  File "C:/<path>/flask-zipkin-test.py", line 10, in <module>
    zipkin.update_tags(id=1, user_id=2)
  File "C:\<path>\venv\lib\site-packages\flask_zipkin.py", line 149, in update_tags
    if all([hasattr(g, '_zipkin_span'),
  File "C:\<path>\venv\lib\site-packages\werkzeug\local.py", line 422, in __get__
    obj = instance._get_current_object()
  File "C:\<path>\venv\lib\site-packages\werkzeug\local.py", line 544, in _get_current_object
    return self.__local()  # type: ignore
  File "C:\<path>\venv\lib\site-packages\flask\globals.py", line 40, in _lookup_app_object
    raise RuntimeError(_app_ctx_err_msg)
RuntimeError: Working outside of application context.

I am not sure if I use the method in a wrong way, if yes, please let me know which part I did it wrong.

I have two applications, one named a and the other named B. their request order is that the client requests application a, and application a requests application B again. The data sent by application B for the first time is OK, but the data sent later is old data

The is_sampled logic there will make it always be False. If the view function is the first span in a trace, X-B3-Sampled is not definded in headers so it is set as Fasle. And then all spans in the call chain will be False.

I use it in two defferent flask applications and no one send trace info to server. When I changed this line to is_sampled = str(headers.get('X-B3-Sampled') or '1') == '1', it worked.